doc: improve AsyncLocalStorage sample #32757
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
async_hooks
targos
approved these changes
Apr 10, 2020
legendecas
approved these changes
Apr 10, 2020
cjihrig
approved these changes
Apr 10, 2020
puzpuzpuz
force-pushed
the
improve-als-sample
branch
from
64036ea to
ef7f5d0
Compare
|
@cjihrig thanks for the suggested changes. I have applied all of them. |
Flarna
approved these changes
Apr 10, 2020
lpinca
approved these changes
Apr 10, 2020
Flarna
added
the
author ready
|
Landed in 82d6726 |
addaleax
pushed a commit
that referenced
this pull request
Apr 13, 2020
PR-URL: #32757 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
4 tasks
|
v12.x backport PR: #32318 |
BethGriggs
pushed a commit
that referenced
this pull request
Apr 14, 2020
PR-URL: #32757 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
puzpuzpuz
added a commit
to puzpuzpuz/node
that referenced
this pull request
Apr 14, 2020
PR-URL: nodejs#32757 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
added
backported-to-v12.x
and removed
author ready
targos
pushed a commit
to targos/node
that referenced
this pull request
Apr 25, 2020
PR-URL: nodejs#32757 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BridgeAR
pushed a commit
that referenced
this pull request
Apr 28, 2020
PR-URL: #32757 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
targos
pushed a commit
that referenced
this pull request
Apr 28, 2020
PR-URL: #32757 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves sample snippet in
AsyncLocalStoragedoc section. Recently I've heard the following complains from one of early adopters of the API:someAsyncOperationfunction)The update tries to address the above items.
cc @vdeturckheim
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes